python.pipInstallHook: avoid producing wrong direct_url.json file#229472
Merged
FRidh merged 1 commit intoNixOS:stagingfrom May 11, 2023
Merged
python.pipInstallHook: avoid producing wrong direct_url.json file#229472FRidh merged 1 commit intoNixOS:stagingfrom
FRidh merged 1 commit intoNixOS:stagingfrom
Conversation
When installing many python packages, a `direct_url.json` file appeared in the lib directory. Example:
```sh
➤ nix build nixpkgs/29755fec55e58a315b517d431b2be261772f2b80#python3Packages.flask
➤ cat result/lib/python3.10/site-packages/Flask-2.2.3.dist-info/direct_url.json
{"archive_info": {}, "url": "file:///build/Flask-2.2.3/dist/Flask-2.2.3-py3-none-any.whl"}⏎
```
As you can see, that file contains a wrong reference to `/build`.
In https://discuss.python.org/t/pep-610-usage-guidelines-for-linux-distributions/4012/4 there's an explanation on how to avoid this. Here, I'm implementing that change for nixpkgs.
@moduon MT-1075
github-actions
bot
added
the
6.topic: python
FRidh
reviewed
May 2, 2023
Member
FRidh
left a comment
FRidh
left a comment
There was a problem hiding this comment.
Nice, thanks!
How many packages did you test with this change?
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
Author
|
I've tested like 4-5 packages. I was finding this problem for something I was packaging myself, and then found out that it happens on every package in nixpkgs. But of course I didn't check "every" package 😅 |
Contributor
Author
|
Thanks for merging! BTW other packages have a hook that check there are no references to |
Contributor
|
Bisect claims that bff6c67 |
Contributor
Author
|
Hello, I can't reproduce because there's some dependency failing too. I'm checked out at today's DetailsHow may I proceed? |
Contributor
|
|
Member
|
If noone gets to understand the regressions within a couple days, I'll simply revert this (for now). We were in stabilization phase for 23.05 release and no "breaking changes" were allowed. /cc PR #232237 |
FRidh
added a commit
that referenced
this pull request
May 17, 2023
…file" Certain packages were failing since this was merged. #229472 (comment) This reverts commit bff6c67.
Member
|
Pushed a revert to staging-next in f042784. |
Contributor
Author
|
Hold on, I found the fix. |
12 tasks
Contributor
Author
|
Fix in #232414. |
yajo
added a commit
to moduon/nixpkgs
that referenced
this pull request
Jul 19, 2023
Fix problem detected in NixOS#229472 (comment). Since bff6c67, now pname is expected to match the name of the package that is built by Python standard tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
When installing many python packages, a
direct_url.jsonfile appeared in the lib directory. Example:➤ nix build nixpkgs/29755fec55e58a315b517d431b2be261772f2b80#python3Packages.flask ➤ cat result/lib/python3.10/site-packages/Flask-2.2.3.dist-info/direct_url.json {"archive_info": {}, "url": "file:///build/Flask-2.2.3/dist/Flask-2.2.3-py3-none-any.whl"}⏎As you can see, that file contains a wrong reference to
/build.In https://discuss.python.org/t/pep-610-usage-guidelines-for-linux-distributions/4012/4 there's an explanation on how to avoid this. Here, I'm implementing that change for nixpkgs.
@moduon MT-1075
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)